Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn about gzip timestamps #979

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/tar.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/tar.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ We also provide full control for tar'ring binaries including their runfiles.
The `tar` binary is hermetic and fully statically-linked.
It is fetched as a toolchain from https://github.com/aspect-build/bsdtar-prebuilt.

## Important Note

When using `compress = "gzip"` its important to disable the non-deterministic time header by providing the `--options=gzip:!timestamp` option.

See: https://datatracker.ietf.org/doc/html/rfc1952#page-5
See: https://github.com/bazel-contrib/bazel-lib/issues/783

## Examples

See the [`tar` tests](/lib/tests/tar/BUILD.bazel) for examples of usage.
Expand Down
Loading