fix: exclude context from pydantic errors #22 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevanmilic
force-pushed
the
feature/issue-22
branch
2 times, most recently
from
437d524 to
93566ae
Compare
|
looks like the ci has some issue regarding ubuntu with with python3.7, I think it might be time to drop it. Also seems to have some minor lint issue with one unused variable. |
stevanmilic
force-pushed
the
feature/issue-22
branch
from
93566ae to
e678137
Compare
stevanmilic
force-pushed
the
feature/issue-22
branch
from
e678137 to
31ec08d
Compare
|
|
Hi @yctomwang, thanks for review! I've fixed the lint issue, and removed 3.7 from test matrix. Please take a look 🙏🏻 |
|
Hi @yctomwang, do you have the time to take a look at this PR? |
|
@stevanmilic Hey Steven, I have been extremely busy with work commits but i promise in the next few days i will get to review this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #86
include_error_url,include_error_context,include_error_inputtovalidate(...)method; the parameters are propagated to pydantic'serrors()method. Providing flexibility in terms of using these values that might break serialization.