COMPAT: Add monkey patch for formulaic #594
Conversation
|
Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-04-16 14:18:26 UTC |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self, | ||
| group: Literal["entity", "time", "both"], | ||
| *, | ||
| return_panel: Literal[False], | ||
| ) -> Float64Array: | ||
| ... | ||
| ) -> Float64Array: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| self, | ||
| group: Literal["entity", "time", "both"] = ..., | ||
| weights: PanelData | None = ..., | ||
| return_panel: Literal[True] = ..., | ||
| low_memory: bool = ..., | ||
| ) -> PanelData: | ||
| ... | ||
| ) -> PanelData: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| self, | ||
| group: Literal["entity", "time", "both"], | ||
| weights: PanelData | None, | ||
| return_panel: Literal[False], | ||
| ) -> Float64Array: | ||
| ... | ||
| ) -> Float64Array: ... # noqa: E704 |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| @@ -23,11 +23,9 @@ | |||
|
|
|||
|
|
|||
| class SupportsKeysAndGetItem(Protocol[_KT, _VT_co]): | |||
| def keys(self) -> Iterable[_KT]: | |||
| ... | |||
| def keys(self) -> Iterable[_KT]: ... # noqa: E704 | |||
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| def __getitem__(self, __k: _KT) -> _VT_co: | ||
| ... | ||
| def __getitem__(self, __k: _KT) -> _VT_co: ... # noqa: E704 |
Check notice
Code scanning / CodeQL
Statement has no effect Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 99.60% 99.58% -0.02%
==========================================
Files 99 100 +1
Lines 17259 17269 +10
Branches 2460 2464 +4
==========================================
+ Hits 17190 17198 +8
+ Misses 30 26 -4
- Partials 39 45 +6 ☔ View full report in Codecov by Sentry. |
No description provided.