Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READY: optional timestamp conversion #275

Merged
merged 4 commits into from
Jun 10, 2016

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Jun 10, 2016

Fixes #274 (CLIENTS-889)

Add an option to enable conversion of timestamp_value data when fetching data from Riak TS. Time objects will always be converted when sent to Riak TS.

@lukebakken lukebakken added this to the riak-ruby-client-2.4.0 milestone Jun 10, 2016
@lukebakken lukebakken self-assigned this Jun 10, 2016
@lukebakken lukebakken changed the title WIP: optional timestamp conversion READY: optional timestamp conversion Jun 10, 2016
@alexmoore
Copy link
Contributor

alexmoore commented Jun 10, 2016

New tests pass, but getting errors on these tests in OS X:

$ ruby --version
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]

riak-ruby-client(features/lrb/optional-timestamp-conversion-gh-274) $ rspec spec/integration/riak/protobuffs/timeouts_spec.rb
Run options:
  include {:focus=>true}
  exclude {:yes_security=>true}

All examples were filtered out; ignoring {:focus=>true}

Protocol Buffers
  timeouts
    raises error on write timeout (FAILED - 1)
    raises error on connect timeout
    raises error on read timeout (FAILED - 2)

Failures:

  1) Protocol Buffers timeouts raises error on write timeout
     Failure/Error: Thread.start(server.accept) do |s|
     Errno::EBADF:
       Bad file descriptor
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:105:in `accept'
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:105:in `block (5 levels) in <top (required)>'
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:103:in `loop'
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:103:in `block (4 levels) in <top (required)>'

  2) Protocol Buffers timeouts raises error on read timeout
     Failure/Error: Thread.start(server.accept) do |s|
     Errno::EBADF:
       Bad file descriptor
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:35:in `accept'
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:35:in `block (5 levels) in <top (required)>'
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:33:in `loop'
     # ./spec/integration/riak/protobuffs/timeouts_spec.rb:33:in `block (4 levels) in <top (required)>'

Finished in 0.87003 seconds (files took 0.50747 seconds to load)
3 examples, 2 failures

Failed examples:

rspec ./spec/integration/riak/protobuffs/timeouts_spec.rb:92 # Protocol Buffers timeouts raises error on write timeout
rspec ./spec/integration/riak/protobuffs/timeouts_spec.rb:23 # Protocol Buffers timeouts raises error on read timeout

Randomized with seed 8069

@alexmoore
Copy link
Contributor

alexmoore commented Jun 10, 2016

Reported those test fails in #276 (CLIENTS-890).

@alexmoore
Copy link
Contributor

+1

@lukebakken lukebakken merged commit 8654838 into master Jun 10, 2016
@lukebakken lukebakken deleted the features/lrb/optional-timestamp-conversion-gh-274 branch June 10, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants