BcCustomContentControllerEventListener::startup()&setAdminMenu() のユニットテスト #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
レビューをお願いします。 |
ryuring
requested changes
Nov 20, 2024
There was a problem hiding this comment.
@HungDV2022 こちらの件、不要なコードが多くありそうですので、不要なコードを削除して整理してもらえますか？
テストの内容としては、dispatch() して、Configure::read('BcApp.adminNavigation.Contents') に期待する値が入ればOKです。
| $dataBaseService = $this->getService(BcDatabaseServiceInterface::class); | ||
| $customTable = $this->getService(CustomTablesServiceInterface::class); | ||
| //カスタムテーブルとカスタムエントリテーブルを生成 | ||
| $customTable->create([ |
There was a problem hiding this comment.
@HungDV2022 このデータは使われてますか？
There was a problem hiding this comment.
@ryuring
このデータは必要です。削除したらカスタムコンテンツをAdminMenuに反映しませんでした。
| $this->loadFixtureScenario(InitAppScenario::class); | ||
| $this->eventManager = EventManager::instance(); | ||
|
|
||
| $this->BcAuthenticationEventListener = new BcCustomContentControllerEventListener(); |
There was a problem hiding this comment.
@HungDV2022 変数名がおかしくないですか？
|
@HungDV2022 ありがとうございました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.