add unitTest_BlogHelper_isSingle #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryuring レピューをお願いします。 |
ryuring
reviewed
Mar 4, 2024
| $this->assertFalse($result); | ||
|
|
||
| //param is not empty | ||
| $this->Blog->getView()->setRequest($this->getRequest('/news/archives/2016/02/10/post-1')->withAttribute('currentSite', SiteFactory::get(1))); |
There was a problem hiding this comment.
@thangnnmd @HungDV2022 実際の動作では、URLが、/news/archives/2016/02/10/post-1 の場合、blogArchiveType が daily に設定されますので、仕様として誤解を生みそうです。次のURLに変更してください。
/news/archives/1
こちらが isSingleの際のURLとなります。
There was a problem hiding this comment.
@ryuring URLを変更しました。確認お願いします。
ryuring
reviewed
Mar 5, 2024
| $this->assertTrue($result); | ||
|
|
||
| //BlogArchiveType is not empty | ||
| $this->Blog->getView()->setRequest($this->getRequest('/news/archives/1')->withAttribute('currentSite', SiteFactory::get(1))); |
There was a problem hiding this comment.
@HungDV2022 こっちは前のURLの方が正しかったです
There was a problem hiding this comment.
@ryuring こちらを修正しました。確認お願いします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add BlogHelper::isSingle