Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unitTest_BlogCategoriesTable_getByName #3170

Closed
wants to merge 1 commit into from
Closed

add unitTest_BlogCategoriesTable_getByName #3170

wants to merge 1 commit into from

Conversation

thangnnmd
Copy link
Collaborator

add unit test BlogCategoriesTable::getByName

@thangnnmd
Copy link
Collaborator Author

@HungDV2022 Please take a look

@HungDV2022
Copy link
Collaborator

@ryuring レピューお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Feb 27, 2024
], $options);
$this->unbindModel(['hasMany' => ['BlogPost']]);
return $this->find('first', $options);
return $this->find()->where([
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thangnnmd @HungDV2022 $options が使われていませんので、find() の第2引数に入れてください。
第一引数は、'all' で大丈夫です。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Feb 29, 2024
@ryuring ryuring added the Reviewed レビュー済 label Feb 29, 2024
@HungDV2022 HungDV2022 removed their assignment Feb 29, 2024
@HungDV2022 HungDV2022 closed this Mar 5, 2024
@momofff momofff added this to the close milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants