Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユニットテスト BlogCommentsService::add #3085

Merged
merged 6 commits into from
Feb 26, 2024
Merged

ユニットテスト BlogCommentsService::add #3085

merged 6 commits into from
Feb 26, 2024

Conversation

thangnnmd
Copy link
Collaborator

No description provided.

@HungDV2022 HungDV2022 assigned thangnnmd and unassigned HungDV2022 Feb 6, 2024
@ryuring ryuring added this to the 5.0.9 milestone Feb 15, 2024
@thangnnmd thangnnmd assigned HungDV2022 and unassigned thangnnmd Feb 21, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 Please take a look

@HungDV2022
Copy link
Collaborator

@thangnnmd レピューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Feb 22, 2024
);
BlogPostFactory::make(['id' => 1, 'blog_content_id' => 1])->persist();
$data = [
'id' => 1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlogCommentは、id、no、status 自動生成ですので、post しても意味がありませんので、削除お願いします。
@HungDV2022 @thangnnmd

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Feb 25, 2024
@ryuring ryuring added the Reviewed レビュー済 label Feb 25, 2024
@ryuring ryuring modified the milestones: 5.0.9, 5.0.11 Feb 25, 2024
@HungDV2022 HungDV2022 removed their assignment Feb 25, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 please take a look

@thangnnmd thangnnmd assigned HungDV2022 and unassigned thangnnmd Feb 26, 2024
@HungDV2022
Copy link
Collaborator

@ryuring 修正しました。レピューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Feb 26, 2024
@ryuring
Copy link
Collaborator

ryuring commented Feb 26, 2024

@HungDV2022 @thangnnmd ありがとうございます。マージします。

@ryuring ryuring merged commit 5da3f64 into baserproject:dev-5.1 Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants