-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ユニットテスト BlogCommentsService::add #3085
Merged
ryuring
merged 6 commits into
baserproject:dev-5.1
from
thangnnmd:unitTest_BlogCommentsService_Add
Feb 26, 2024
Merged
ユニットテスト BlogCommentsService::add #3085
ryuring
merged 6 commits into
baserproject:dev-5.1
from
thangnnmd:unitTest_BlogCommentsService_Add
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HungDV2022
reviewed
Feb 6, 2024
@HungDV2022 Please take a look |
@thangnnmd レピューをお願いします。 |
ryuring
reviewed
Feb 25, 2024
); | ||
BlogPostFactory::make(['id' => 1, 'blog_content_id' => 1])->persist(); | ||
$data = [ | ||
'id' => 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BlogCommentは、id、no、status 自動生成ですので、post しても意味がありませんので、削除お願いします。
@HungDV2022 @thangnnmd
@HungDV2022 please take a look |
@ryuring 修正しました。レピューをお願いします。 |
@HungDV2022 @thangnnmd ありがとうございます。マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.