Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2842 php8の環境において、コンテンツ一覧画面でメールフォーム複製時にエラーが表示される #2843

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

fuchigam1
Copy link
Collaborator

issueはこちらです。 #2842
調整したので取込検討お願いします

@ryuring
Copy link
Collaborator

ryuring commented Nov 6, 2023

@fuchigam1 プルリクありがとうございます。
こちら少し解説を頂いてもいいでしょうか?

@ryuring ryuring added the Reviewed レビュー済 label Nov 6, 2023
@fuchigam1
Copy link
Collaborator Author

@ryuring 遅くなっちゃってすみません!
既にphp8対応は済んでいる状態なので、ちょっと漏れている箇所だと見て同様の内容探って入れましたー
・コミット 7d3e405bd
・箇所 7d3e405bd#diff-a1313b792a278f10019b9c925fd43267e7ebf0b62c4956612b8b5fb79d85d681L70

@ryuring
Copy link
Collaborator

ryuring commented Nov 24, 2023

@fuchigam1 PHP8対応というこですね。了解しました。マージしますね。

@ryuring ryuring merged commit 2e5cf55 into baserproject:dev-4 Nov 24, 2023
1 check passed
@momofff momofff added this to the 4.9.0 milestone Nov 24, 2023
@fuchigam1 fuchigam1 deleted the issues-2842 branch December 24, 2023 00:41
@momofff momofff modified the milestones: 4.9.0, 4.8.1 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants