BcUploaderを全体テストの実行対象に追加する #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # phpunit.xml.dist
ryuring
requested changes
Nov 7, 2023
| @@ -358,11 +358,6 @@ public function test_upload() | |||
| //テストファイルとフォルダを削除 | |||
| rmdir($filePath); | |||
| unlink($fullpath . 'uploadTestFile.html'); | |||
|
|
|||
| //エラーを発生した場合 | |||
| $this->post('/baser/admin/bc-theme-file/theme_files/index/BcThemeSample/layout3'); | |||
There was a problem hiding this comment.
@HungDV2022 削除した理由はなんでしょうか？
There was a problem hiding this comment.
@ryuring
こちらと同じ理由です。#2844 (comment)
| @@ -277,30 +279,16 @@ public function test_update() | |||
| //正常系実行 | |||
| $entity = $this->UploaderFilesService->update($entity, $postData); | |||
| $this->assertEquals('test.jpg', $entity->name); | |||
| //異常系実行 | |||
| @@ -316,7 +304,7 @@ public function test_isEditable() | |||
| 'user_id' => 99 | |||
| ]; | |||
| $result = $this->UploaderFilesService->isEditable($postData); | |||
| $this->assertFalse($result); | |||
There was a problem hiding this comment.
@HungDV2022 仕様が変わってしまっています。理由はなんですか？
There was a problem hiding this comment.
@ryuring https://github.com/baserproject/basercms/pull/2838/files/efba8b5317f3410f13d2ea06da78f2f74e51c578#r1385795775
こちらと同じ理由でメソッドを分けてテスト方がいいだと思います。同じメソッドを書くと期待値が変わります。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.