Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2783 CGIモードでJWT認証が可能になるようにしたい #2784

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

gondoh
Copy link
Collaborator

@gondoh gondoh commented Oct 5, 2023

ご検討おばおねがいします!

Copy link
Collaborator

@ryuring ryuring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gondoh レビュー入れました。あと、テストが失敗しているのでご確認くださいまし。

@@ -280,9 +280,9 @@ public function middleware(MiddlewareQueue $middlewareQueue): MiddlewareQueue
{
$middlewareQueue
->insertBefore(CsrfProtectionMiddleware::class, new AuthenticationMiddleware($this))
->insertBefore(AuthenticationMiddleware::class, new BcRequestFilterMiddleware($this))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gondoh insertBefore使わなくても単純に一番上に書けば大丈夫です

@ryuring ryuring added the Reviewed レビュー済 label Oct 5, 2023
@gondoh
Copy link
Collaborator Author

gondoh commented Oct 5, 2023

@ryuring
テスト改善したのでご確認おねがいします!

@gondoh gondoh assigned ryuring and unassigned gondoh Oct 5, 2023
@ryuring
Copy link
Collaborator

ryuring commented Oct 5, 2023

@gondoh ありがとうございます、マージしますね

@ryuring ryuring merged commit 39d798a into dev-5 Oct 5, 2023
2 checks passed
@gondoh gondoh added this to the 5.0.6 milestone Oct 19, 2023
@ryuring ryuring deleted the 2783 branch December 6, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants