Add unitTest_MailMessagesController_download (#3983)

Co-authored-by: thangnn <[email protected]>
baserproject · Nov 7, 2024 · d8b2b37 · d8b2b37
1 parent 92067ca
commit d8b2b37
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/plugins/bc-mail/src/Controller/Api/Admin/MailMessagesController.php b/plugins/bc-mail/src/Controller/Api/Admin/MailMessagesController.php
@@ -314,6 +314,7 @@ public function batch(MailMessagesServiceInterface $service, $mailContentId)
      *
      * @checked
      * @noTodo
+     * @unitTest
      */
     public function download(MailMessagesAdminServiceInterface $service, int $mailContentId)
     {

diff --git a/plugins/bc-mail/src/Service/Admin/MailMessagesAdminService.php b/plugins/bc-mail/src/Service/Admin/MailMessagesAdminService.php
@@ -86,11 +86,12 @@ public function getViewVarsForView(int $mailContentId, int $mailMessageId)
      */
     public function getViewVarsForDownloadCsv(int $mailContentId, ServerRequest $request)
     {
+        $currentContent = $request->getAttribute('currentContent');
         $this->setup($mailContentId);
         return [
             'encoding' => $request->getQuery('encoding') ?? 'utf-8',
             'messages' => $this->MailMessages->convertMessageToCsv($this->getIndex()->all()->toArray()),
-            'contentName' => $request->getAttribute('currentContent')?->name,
+            'contentName' => $currentContent ? $request->getAttribute('currentContent')?->name : '',
         ];
     }
 

diff --git a/plugins/bc-mail/tests/TestCase/Controller/Api/Admin/MailMessagesControllerTest.php b/plugins/bc-mail/tests/TestCase/Controller/Api/Admin/MailMessagesControllerTest.php
@@ -362,6 +362,18 @@ public function testBatch()
      */
     public function testDownload()
     {
-        $this->markTestIncomplete('このテストは、まだ実装されていません。');
+        // メールメッセージのデータを作成する
+        $MailMessagesService = $this->getService(MailMessagesServiceInterface::class);
+        //テストデータベースを生成
+        $MailMessagesService->createTable(1);
+        $mailMessageTable = TableRegistry::getTableLocator()->get('BcMail.MailMessages');
+        $mailContentId = 1;
+        $mailMessageTable->setup($mailContentId);
+        $mailMessageTable->save(new Entity(['id' => 2]));
+
+        ob_start();
+        $this->get("/baser/api/admin/bc-mail/mail_messages/download/1.json?token=$this->accessToken");
+        $actual = ob_get_clean();
+        $this->assertNotEmpty($actual);
     }
 }