add comment and add unitTest_BlogCategoriesTable_getByName

baserproject · Feb 28, 2024 · 3d3beae · 3d3beae
1 parent 078fbda
commit 3d3beae
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/plugins/bc-blog/src/Model/Table/BlogCategoriesTable.php b/plugins/bc-blog/src/Model/Table/BlogCategoriesTable.php
@@ -355,6 +355,9 @@ public function hasChild($id)
      * @param int $blogContentId
      * @param string $name
      * @param array $options
+     * @notodo
+     * @checked
+     * @unitTest
      * @return EntityInterface
      */
     public function getByName($blogContentId, $name, $options = [])

diff --git a/plugins/bc-blog/src/View/Helper/BlogHelper.php b/plugins/bc-blog/src/View/Helper/BlogHelper.php
@@ -2023,6 +2023,8 @@ public function isSameSiteBlogContent($blogContentId)
      * @param string $categoryName
      * @param array $options
      * @return EntityInterface
+     * @notodo
+     * @checked
      * @unitTest
      */
     public function getCategoryByName($blogContentId, $categoryName = '', $options = [])

diff --git a/plugins/bc-blog/tests/TestCase/Model/BlogCategoriesTableTest.php b/plugins/bc-blog/tests/TestCase/Model/BlogCategoriesTableTest.php
@@ -498,15 +498,19 @@ public function testHasChild()
 
     /**
      * カテゴリ名よりカテゴリを取得する
+     * getByName
      * @dataProvider getByNameDataProvider
      * @param int $blogCategoryId
      * @param string $name
      * @param bool $expects
      */
     public function testGetByName($blogCategoryId, $name, $expects)
     {
-        $this->markTestIncomplete('こちらのテストはまだ未確認です');
-        $result = $this->BlogCategory->getByName($blogCategoryId, $name);
+        //データ生成
+        BlogCategoryFactory::make(['name' => 'child', 'blog_content_id' => 1])->persist();
+        BlogCategoryFactory::make(['name' => 'name', 'blog_content_id' => 2])->persist();
+        $result = $this->BlogCategoriesTable->getByName($blogCategoryId, $name);
+        //戻り値を確認
         $this->assertEquals($expects, (bool)$result);
     }