fix #3226 【お気に入り】お気に入り一覧に別のユーザーのデータまで表示される (#3228)

Co-authored-by: Đỗ Văn Hùng <[email protected]>

plugins/bc-favorite/src/Service/FavoritesService.php

@@ -11,6 +11,7 @@
 
 namespace BcFavorite\Service;
 
+use BaserCore\Utility\BcUtil;
 use Cake\Datasource\EntityInterface;
 use Cake\ORM\Exception\PersistenceFailedException;
 use Cake\ORM\Query;
@@ -68,8 +69,9 @@ public function getIndex(array $queryParams): Query
         if (!empty($queryParams['num'])) {
             $options = ['limit' => $queryParams['num']];
         }
-        $query = $this->Favorites->find('all', ...$options)->orderBy(['sort']);
-        return $query;
+        return $this->Favorites->find('all', $options)->where(
+            ['user_id' => BcUtil::loginUser()->id]
+        )->orderBy(['sort']);
     }
 
     /**

plugins/bc-favorite/tests/TestCase/Service/FavoritesServiceTest.php

@@ -90,6 +90,8 @@ public function testGet(): void
      */
     public function testGetIndex(): void
     {
+        $this->loadFixtureScenario(InitAppScenario::class);
+        $this->loginAdmin($this->getRequest());
         $this->loadFixtureScenario(FavoritesScenario::class);
         $result = $this->FavoritesService->getIndex(['num' => 2]);
         $this->assertEquals(2, $result->all()->count());
@@ -144,6 +146,8 @@ public function testUpdate(): void
     public function testDelete()
     {
         $this->loadFixtureScenario(FavoritesScenario::class);
+        $this->loadFixtureScenario(InitAppScenario::class);
+        $this->loginAdmin($this->getRequest());
         $this->FavoritesService->delete(1);
         $users = $this->FavoritesService->getIndex([]);
         $this->assertEquals(5, $users->all()->count());