Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crt renderer init #46

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

crt renderer init #46

wants to merge 21 commits into from

Conversation

git-chad
Copy link
Contributor

@git-chad git-chad commented Nov 22, 2024 •
edited
Loading

include a short description for this PR, and/or link any related issues that this PR addresses ← and then delete me.

Checklist

  • Related issues linked.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code and it's looking great.
  • I have tested my changes in desktop.
  • I have tested my changes in a mobile device.
  • I have tested my changes in dark and light mode (if applicable).

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:51pm

@git-chad git-chad marked this pull request as ready for review November 25, 2024 13:24
matiasngf
matiasngf requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@matiasngf matiasngf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful work! left a minor comment to improve perf

src/experiments/78.crt-renderer/_components/scene.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasngf matiasngf matiasngf requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@motiontx motiontx

@git-chad git-chad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-chad @matiasngf @motiontx