mark-yank-url: Generic url support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a more generic URL parser, although not fully conforming to RFC3986, it does try to place as few restrictions as possible on the URL, while still not matching noise.
This change introduces the concept of "handler", a command that handles a specific protocol. E.g., x-www-browser for handling http, https and ftp (default). Pressing enter when marking URLs with other schemes will no op. This still leaves us with the possibility to yank the URL to the clipboard.
Guess scheme to be "http" if there is no real scheme in the URL, but the domain is "www.*".
|
PS. This would thus also solve #1. |
|
Ping? I'm also having this issue. |
foo() vs foo{}
This fixes warnings like (as seen on urxvt's stdout/err), if one ever
gets the idea of middle clicking a link:
Odd number of elements in anonymous hash at $HOME/.urxvt/mark-yank-urls line 104.
Use of uninitialized value $scheme in hash element at $HOME/.urxvt/mark-yank-urls line 40.
This bug was introduced in my commit adding "ability to define handlers
per protocol". Because of the age of the branch, I will refrain from
rebasing and let this be a tombstone of one of my many mistakes
throughout the years. The expected behavior (processing links on mouse
button2 key release) was confirmed to be working with this change
applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the url_matcher regexp to support generic URLs (i.e no need explicitly support "exotic" schemes like sftp, git etc). This branch also introduces "handlers", to be able to define different commands for different protocols (based on URL scheme).
In my humble opinion, the use of Regexp::Common::URI to handle URIs is flawed for this particular use case, in that it does not account for the "trailing character heuristic" and does not support HTTPS out of the box (you have to override to scheme regexp, as per the Regexp::Common::URI::HTTP documentation). The option to use Regexp::Common::URI is removed in this branch.
Please review carefully! I've only used it now for an hour or so and have yet to stumble upon really exotic corner cases :-).