Issue 310 include lang namespaces #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #310
It creates a new database table (
ltm_namespaces) to store declared translation namespaces' language paths.It refactors the import and export processes to handle registered namespaces in service providers. It creates groups with the form
namespace::groupfor each of them. It also breaks down each vendor translations into a separate group (vendor/vendorname/group) instead of joining all translations into a single one.The
Manager::importTranslations()method, AFAIK, is only publicly called with the$replaceargument and both other arguments are for internal use, so I refactored it to have only this argument and broke it down into two other methods, one for array translations and another for JSON.