Merge pull request #107 from barriosnahuel/fix/node-installation

Fix/node installation

CHANGELOG.md

@@ -1,3 +1,8 @@
+# v2.4.1
+## Fixed
+- Duplicated logs.
+- NodeJS and npm installation.
+
 # v2.4.0
 ## Added
 - GIT diff-so-fancy to use `git diff` the right way. #70

functions.sh

@@ -20,7 +20,7 @@ logInfo (){
 }
 
 logSummary (){
-    echo "INFO  - EFU: $1 $2 $3"
+    logInfo "$1 $2 $3"
     echo "INFO  - EFU: $1 $2 $3" >> ~/Downloads/summary.efu.log
 }
 
@@ -29,8 +29,7 @@ logAlreadyInstalled (){
 }
 
 logProgramVersion (){
-    logInfo "$1" "$2" "$3"
-    logSummary "Installed $1 $2 $3" >> ~/Downloads/summary.efu.log
+    logSummary "Installed $1 $2 $3"
 }
 
 preInstallationLog(){

modules/nodejs.sh

@@ -1,12 +1,18 @@
 #!/bin/bash
 # Created by Nahuel Barrios on 24/3/16.
+# shellcheck disable=SC1090
 
 enterDirOrExit "${CURRENT_DIR}"
 
 if ! command -v nvm >/dev/null; then
     preInstallationLog "NVM"
     curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.34.0/install.sh | bash
-    logInfo "Remember to add --no-use to your .zshrc as mentioned here: https://github.com/creationix/nvm#install--update-script"
+
+    # Required to be able to call > nvm XXX on current terminal session.
+    export NVM_DIR="$HOME/.nvm"
+    [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
+    [ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
+
     postInstallationLog "NVM"
 else
     logAlreadyInstalled "NVM"