Added option to specify target mount point #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoHood
reviewed
Nov 22, 2020
| UUIDS=$($ssh findmnt -n -v -t btrfs -o UUID --list) | ||
| fi | ||
|
|
||
| if [[ "$mountpoint_cmdline" == "none" ]]; then | ||
| TARGETS=$DETECTED_TARGETS | ||
| else |
There was a problem hiding this comment.
The indention is wrong here
| TARGETS=$DETECTED_TARGETS | ||
| else | ||
| if grep -q "$mountpoint_cmdline" <<< "$DETECTED_TARGETS" ;then | ||
| TARGETS=$mountpoint_cmdline |
There was a problem hiding this comment.
Wouldnt it make sense to escape the variable here when the path contains spaces?
| if [[ "$mountpoint_cmdline" == "none" ]]; then | ||
| TARGETS=$DETECTED_TARGETS | ||
| else | ||
| if grep -q "$mountpoint_cmdline" <<< "$DETECTED_TARGETS" ;then |
There was a problem hiding this comment.
I am not sure if this single grep is satisfying enough. Or at least it could be improved. I did not test this, but what if detected targets contains /mnt/test but you specified /mnt via the command line? An exact match would be better here.
|
Closing since no response to requests for more info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR implements the option
--mountpointwhere one can specify the target mount point to be used when the volume is mounted in more that one location. Fix for #71