First pass at refinery.js #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slow because it's using localhost and not prod |
lgvital
approved these changes
Apr 13, 2021
static/js/refinery.js
Outdated
| let changes = response[0].changes; | ||
| changes.forEach(change => { | ||
| if (window.location.href == change.href) { | ||
| let domPath = document.querySelector(change.domPath); |
There was a problem hiding this comment.
nit - probably more readable to have this be let elem since it's an HTMLElement that gets loaded up with querySelector
static/js/refinery.js
Outdated
Comment on lines
71
to
86
| changes.forEach(change => { | ||
| if (window.location.href == change.href) { | ||
| let domPath = document.querySelector(change.domPath); | ||
| if (domPath.innerHTML != change.beforeHtml) { | ||
| console.warn(`Can't apply change on '${change.beforeHtml}' because copy doesn't match.\ | ||
| '${change.beforeHtml}' vs. '${domPath.innerHTML}'.`); | ||
| } else { | ||
| domPath.innerHTML = change.afterHtml; | ||
| } | ||
| } else { | ||
| console.warn(` | ||
| Can't apply change on '${change.beforeHtml}' because href's don't match.\ | ||
| '${change.href}' vs. '${window.location.href}'.`); | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
this is great stuff, we'll probably eventually want to move this into a shareable module so that refinerybrowser can use this (for deleted nodes, prevent accidentally losing changes, etc.)!
jogly
approved these changes
Apr 13, 2021
| if (window.location.href == change.href) { | ||
| let domPath = document.querySelector(change.domPath); | ||
| if (domPath.innerHTML != change.beforeHtml) { | ||
| console.warn(`Can't apply change on '${change.beforeHtml}' because copy doesn't match.\ |
Co-authored-by: Lionel Vital <[email protected]>
Co-authored-by: Lionel Vital <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example.mov