Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when no IP can be fetched #58

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Don't fail when no IP can be fetched #58

merged 1 commit into from
Jan 14, 2021

Conversation

econti
Copy link
Collaborator

@econti econti commented Jan 14, 2021

  • Don't fail when no IP can be fetched - just set an IP since it's only used for experiment bucketing
  • Use pipenv for ecommerce repo

Copy link
Collaborator

@lgvital lgvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment on lines +1 to +13
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
flask = "*"
instamojo-wrapper = "*"

[dev-packages]

[requires]
python_version = "3.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!

@econti econti merged commit 57d4f0f into master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants