Clear context for experiment when logging (delayed) reward #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool. what about when a user's IP address changes. do we ever check that / do you think it is worth checking? |
econti
reviewed
Apr 21, 2020
| this.storage.removeItem(this.sessionIdKey); | ||
| this.storage.removeItem(this.lastActionTimeKey); | ||
| this.clearContext(experimentId); |
There was a problem hiding this comment.
does this clear IP & auto-context (cache)?
There was a problem hiding this comment.
ah good catch, forgot cache is keyed separately. adding.
Presumably, if the IP is in their local storage, it's the same user/device, just (possibly) on a different network. I think it makes sense to treat it as a single user until the session is over, but open to changing my mind. |
econti
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lmk if we should be more aggressive in clearing context. The con would be hitting ipify limits earlier.