Remove feature possible values validation aside from type #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
econti
reviewed
Apr 20, 2020
static/js/banditMl.js
Outdated
| @@ -257,10 +257,6 @@ banditml.BanditAPI.prototype.validateAndFilterFeaturesInContext = function (cont | |||
| Array.isArray(possibleValues), | |||
static/js/banditMl.js
Outdated
| self.assert( | ||
| possibleValues.includes(context[featureName]), | ||
| `Value ${value} is not recognized among possible values for feature ${featureName}. Please update the possible values in Bandit ML.` | ||
| ); | ||
| } else if (featureType === "P") { | ||
| self.assert( | ||
| Array.isArray(possibleValues), |
There was a problem hiding this comment.
thats true, we'll probably remove this field completely. removing!
jogly
approved these changes
Apr 20, 2020
static/js/banditMl.js
Outdated
| self.assert( | ||
| Array.isArray(possibleValues), | ||
| `Feature ${featureName} is a product set, but its possible values is not an array. Update the model appropriately in Bandit ML.` | ||
| ); | ||
| self.assert( | ||
| typeof value === "string" || Array.isArray(value), |
There was a problem hiding this comment.
not now, but worthwhile to validate string or array specifically of strings?
There was a problem hiding this comment.
good call, yes! ill add it in here since it's relatively trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.