Skip to content

Commit

Permalink
Merge pull request #55 from banditml/gilley/no-clear
Browse files Browse the repository at this point in the history
dont clear session on delayed rewards
  • Loading branch information
jogly authored Jun 18, 2020
2 parents a1514bc + 6db4440 commit dfab144
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions static/js/banditMl.js
Original file line number Diff line number Diff line change
Expand Up @@ -671,10 +671,6 @@ banditml.BanditAPI.prototype.logReward = function(reward, experimentId = null, d
console.log("Successfully logged reward.");
console.log(response);
}
if (decisionId === null) {
// TODO: edge case - do we clear session in case of failures too?
this.clearSession(experimentId);
}
return response;
}).catch(e => {
this.logError("Failed to log reward", postBody, e);
Expand Down

0 comments on commit dfab144

Please sign in to comment.