Fix validation issue breaking L&G

banditml · Jun 18, 2020 · 3e54edd · 3e54edd
1 parent de97c33
commit 3e54edd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/static/js/banditLocal.js b/static/js/banditLocal.js
@@ -5,6 +5,6 @@ let bandit = new banditml.BanditAPI(
   config = {
     debugMode: true,
     banditHostUrl: "http://localhost:8000/api/",
-    debugOptions: {forceVariantSlug: "bandit"}
+    debugOptions: {forceVariantSlug: "tf"}
   }
 );
diff --git a/static/js/banditMl.js b/static/js/banditMl.js
@@ -66,6 +66,9 @@ banditml.BanditAPI = function (apiKey, recClassByExperimentId = {}, config = {})
 
   // URLs & hosts
   this.ipUrl = "https://api.ipify.org?format=json";
+
+  // special features known to backend
+  this.reservedFeatures = ["ipAddress", "currentlyViewingProduct"]
 };
 
 banditml.BanditAPI.prototype.addDecisionHandler = function (context, decision, experimentId) {
@@ -282,8 +285,8 @@ banditml.BanditAPI.prototype.validateAndFilterFeaturesInContext = function (cont
   };
   let filteredFeatures = {};
   for (const featureName in context) {
-    if (featureName === "ipAddress") {
-      filteredFeatures.ipAddress = context.ipAddress;
+    if (self.reservedFeatures.includes(featureName)) {
+      filteredFeatures[featureName] = context[featureName];
       continue;
     }