Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiles with llvm 17. Solves #98. #99

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Conversation

HFTrader
Copy link
Contributor

There is a single change in ABI that breaks compiling with clang-17: LLVMModule::getGlobalList() to LLVMModule::globals(). That was wrapped with an #if

A second change is to match any provided LLVM version in find_package() and use a second check to match major versions from 16 to 17. The reason for this is that even though we can provide a version range in find_package(), the LLVMConfigVersion.cmake installed with the llvm distribution will only match exactly the MAJOR.MINOR version.

Copy link
Owner

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thank you for preparing and sending this 🙏🏻

In general, I try to keep llvm-tutor based on the latest release (that simplifies a lot of things), but LLVM 17 isn't out yet. This change will simplify the transition once the release happens.

LGTM

@banach-space banach-space merged commit 4e980f9 into banach-space:main Sep 17, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants