Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include of legacy include file #100

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove include of legacy include file #100

merged 1 commit into from
Oct 17, 2023

Conversation

kippesp
Copy link
Contributor

@kippesp kippesp commented Oct 12, 2023

Upstream LLVM commit d623b2f95fd559901f008a0588dddd0949a8db01 removed PassManagerBuilder and its header file.

@kippesp
Remove include of legacy include file
398c5ec 
Upstream LLVM commit d623b2f95fd559901f008a0588dddd0949a8db01 removed
PassManagerBuilder and its header file.
@kippesp
Copy link
Contributor Author

kippesp commented Oct 12, 2023

This was checked against 16.0.6 as well.

@csyJoy
Copy link

csyJoy commented Oct 13, 2023

Same problem happens to me in llvm 17.0.2, this pr LGTM

banach-space
banach-space approved these changes Oct 17, 2023
View reviewed changes
Copy link
Owner

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution and apologies for the delay, LGTM :)

@banach-space banach-space merged commit 513506c into banach-space:main Oct 17, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banach-space banach-space banach-space approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kippesp @csyJoy @banach-space