Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a move to safe position to A1 and A1 mini change filament gcode #5219

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tsmith35
Copy link

Previous versions of these two files did not return the nozzle to a safe position after performing a wipe, leaving the nozzle positioned outside of the printable area after finishing. This can cause problems if the nozzle subsequently attempts to move in a direction that may exceed the physical limits of the machine.

Added this to the end of each nozzle wipe & shake block:
G1 X0 F18000 ; move to safe pos
Added this to the end of each nozzle wipe & shake block:
G1 X0 F18000 ; move to safe pos
Forgot to update the date and fixed it.
@tsmith35 tsmith35 changed the title Added a move to safe position to A1 and A1 mini change filament code Added a move to safe position to A1 and A1 mini change filament gcode Nov 13, 2024
@ziehmon
Copy link

ziehmon commented Nov 18, 2024

Hey Tom, so this PR is basically an improved version of #4848. I see you spotted even more situation where we shall move to the safe position. Nice find!

Bambu suggested moving the nozzle to the save position inside the gcode processor, so it's not done by injection (as in our PRs) but rather "hard-coded". I think, we should do both after looking at your gcode modifications actually: keep the safe position in the injected gcode AND ensure it's the final position after the injection ends.

I will reach out in this PR again when I have draft for the "hard-coding", and we can then merge both I'd propose :)

@tsmith35
Copy link
Author

Bambu suggested moving the nozzle to the save position inside the gcode processor, so it's not done by injection (as in our PRs) but rather "hard-coded". I think, we should do both after looking at your gcode modifications actually: keep the safe position in the injected gcode AND ensure it's the final position after the injection ends.

Yes, I believe it to be the safest approach when custom gcode injection is permitted; custom gcode may be unpredictable, therefore the final step of moving the head to a safe position following any such custom gcode will only help improve operational reliability. Trust, but verify.

@tsmith35
Copy link
Author

@XunZhangBambu does everything look okay to merge, or do I need to make any other changes? This is to prepare for the spiral lift modifications, so it would be much easier to implement that once these changes are in place. Just let me know if there is anything else that you need for me to do on this PR to get it ready. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants