Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(datepicker) #877

Merged
merged 100 commits into from
Sep 12, 2023
Merged

♻️ refactor(datepicker) #877

merged 100 commits into from
Sep 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

closes #695

@github-actions github-actions bot added the ♻️ refactor Improve existing code label May 16, 2023
@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system-old ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 1:03pm

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2023

🦋 Changeset detected

Latest commit: 921400a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@baloise/design-system-components Minor
apps-angular Patch
e2e-tests Patch
@baloise/design-system-components-angular Minor
@baloise/design-system-components-react Minor
@baloise/design-system-components-table Minor
@baloise/design-system-components-vue Minor
@baloise/design-system-testing Minor
@baloise/design-system-css Minor
@baloise/design-system-favicons Minor
@baloise/design-system-fonts Minor
@baloise/design-system-icons Minor
@baloise/design-system-maps Minor
@baloise/design-system-tokens Minor
@baloise/design-system-output-target-angular Minor
@baloise/design-system-output-target-react Minor
@baloise/design-system-output-target-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hirsch88
Copy link
Member

/ux-checklist

@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 28, 2023

🧪 UX-Checklist

@clastzoo @samira-liebendoerfer please help us testing this component.

  • iPhone
    • Safari
  • iPad
    • Safari (only responsive relevancy)
  • Android
    • Chrome
  • MacOs
    • Safari
    • Firefox (if there is time)
    • Chrome (if there is time)
  • Windows
    • Edge
    • Chrome
    • Firefox

@samira-liebendoerfer
Copy link
Collaborator

Testing Feedback

General

  • When manually typing the date and completing it in the required format the calendar is still opened (with the chosen DD MM YYY)
    ––> suggestion: calendar closes after completing or on keydown?

  • Border radius top left and bottom left inner corner not rounded

signal-2023-08-28-140239_002
Bildschirmfoto 2023-08-28 um 17 21 57

  • Typing an impossible date is possible, (calendar shows current date)
    signal-2023-08-28-142356_002

iPhone Safari

  • Selected: bg-color behind date very light grey, no bg-color behind calendar icon
    signal-2023-08-28-140753_002

  • Year not scrollable, not swipable
    signal-2023-08-28-174613_002

@clastzoo
Copy link
Collaborator

Android 11 – Chrome 116.0.5845.115

Corner Radius are missing on the left-hand side:
Bildschirm­foto 2023-08-31 um 15 55 12

[QUESTION]
While holding the phone in landscape mode, the user doesn't notice that the picker opened because the keyboard is automatically triggered. Edgecase: Idea: Press opens date picker, additional click inside the date triggers the keyboard. TBD
image

Letters are allowed as an input
image

Scroll is not really working smoothly
image

Mask is not emptied while start pressing keys
https://github.com/baloise/design-system/assets/62377419/cae3c9e1-8c2c-4dd9-8aad-80992c860cb7

@hirsch88
Copy link
Member

hirsch88 commented Sep 12, 2023

??? When manually typing the date and completing it in the required format the calendar is still opened (with the chosen DD MM YYY) –> suggestion: calendar closes after completing or on keydown?

  • Border radius top left and bottom left inner corner not rounded
  • Typing an impossible date is possible, (calendar shows current date)
  • Selected: bg-color behind date very light grey, no bg-color behind calendar icon
  • Year not scrollable, not swipable

@hirsch88 hirsch88 merged commit d9f6aba into main Sep 12, 2023
@hirsch88 hirsch88 deleted the refactor/issue-695 branch September 12, 2023 13:22
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ refactor Improve existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ refactor(datepicker)
4 participants