Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(bal-tabs | bal-nav): Navigation render issue #1537

Merged
merged 3 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-parrots-check.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**nav**: solves insert node issue with main tabs
12 changes: 12 additions & 0 deletions e2e/cypress/e2e/visual/bal-nav-part-3.visual.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,15 @@ describe('bal-nav - long', () => {
})
})
})

describe('bal-nav - tab change', () => {
it('should switch meta nav tab', () => {
cy.visit('/components/bal-nav/test/bal-nav-long.visual.html').platform('desktop').waitForDesignSystem()
cy.contains('Unternehmenskunden').click().waitForComponents().wait(100)
cy.testVisual(`nav-long-desktop-meta-change`, {
errorThreshold: 0.2,
capture: 'viewport',
clip: balViewport['desktop'],
})
})
})
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions packages/core/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ export namespace Components {
* The color to use from your application's color palette.
*/
"color": BalProps.BalButtonColor;
/**
* If `true` the button is aligned over the whole width
*/
"expanded": boolean;
/**
* BalIcon of the open trigger button
*/
Expand Down Expand Up @@ -5128,6 +5132,10 @@ declare namespace LocalJSX {
* The color to use from your application's color palette.
*/
"color"?: BalProps.BalButtonColor;
/**
* If `true` the button is aligned over the whole width
*/
"expanded"?: boolean;
/**
* BalIcon of the open trigger button
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ export const TabNav: FunctionalComponent<TabNavProps> = ({
>
{tabs.map((tab, index) => (
<bal-carousel-item
key={tab.value}
htmlRole={''}
class={{
...bemEl.element('carousel').element('item').class(),
Expand Down
Loading