Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAVE_INPUT_SHAPER is not a valid command, SET_INPUT_SHAPER is. #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

consp
Copy link
Contributor

@consp consp commented Jun 14, 2024

See https://www.klipper3d.org/G-Codes.html?h=set_input_shaper#set_input_shaper

Maybe this is k1 specific but SAVE_INPUT_SHAPER is not a klipper command in at least v0.11. I have not change the one in the k1 scripts file.

@ballaswag
Copy link
Owner

Hmm I'm not aware of the set variant.

Guppy uses some of its own klippy extras to do some of these things:

https://github.com/ballaswag/creality_k1_klipper_mod/blob/b0c11f514a9111c7e6c0e9bc2dce18857588e4de/build_scripts/buildroot/post_build.sh#L218

@consp
Copy link
Contributor Author

consp commented Jun 14, 2024

Could be a extra command, haven't found it anywhere but the set_input_shaper is the default klipper one.

https://github.com/ballaswag/guppyscreen/blob/7c169647c78cd0c746b8dc3cae06ac3205e3fba8/k1/scripts/shaper_calibrate.py#L344C1-L347C58

Uses set_input_shaper so that is correct. But for the gcode command send over the network (not via python script) is not doing anything. I've tried googeling the SAVE_INPUT_SHAPER but it gives zero results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants