Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_types_balena.bbclass: Move image signing code here #3597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

floion
Copy link
Contributor

@floion floion commented Jan 16, 2025

This fixes the following error:

cp: cannot stat '/work/build/tmp/deploy/images/generic-amd64/balena-image-generic-amd64.balenaos-img.sig': No such file or directory

The signed image symlink is not generated before the flasher needs it so we avoid this dependency issue by defining a new image type for which the build system will automatically create the appropriate symlink.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@floion floion requested a review from a team January 16, 2025 09:22
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion had a problem deploying to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Failure
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion had a problem deploying to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Failure
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion had a problem deploying to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Failure
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 09:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion had a problem deploying to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Failure
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 11:43 — with GitHub Actions Inactive
@floion
Copy link
Contributor Author

floion commented Jan 16, 2025

Hi @klutchell just a heads up that I pushed a change to this PR but that did not make it invalidate the policy-bot. Even more, I also re-requested another review from @alexgg but policy-bot is still marking the PR as approved.

Copy link
Contributor

@alexgg alexgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fails - needs some work

@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:12 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:12 — with GitHub Actions Inactive
@floion floion deployed to balena-cloud.com January 16, 2025 12:12 — with GitHub Actions Active
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:22 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 12:22 — with GitHub Actions Inactive
@floion floion requested a review from alexgg January 16, 2025 12:33
@floion
Copy link
Contributor Author

floion commented Jan 16, 2025

Still fails - needs some work

It worked now but fails for an unrelated issue: https://github.com/balena-os/meta-balena/actions/runs/12808128684/job/35710334625?pr=3597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants