-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image_types_balena.bbclass: Move image signing code here #3597
base: master
Are you sure you want to change the base?
Conversation
Hi @klutchell just a heads up that I pushed a change to this PR but that did not make it invalidate the policy-bot. Even more, I also re-requested another review from @alexgg but policy-bot is still marking the PR as approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still fails - needs some work
It worked now but fails for an unrelated issue: https://github.com/balena-os/meta-balena/actions/runs/12808128684/job/35710334625?pr=3597 |
This fixes the following error:
cp: cannot stat '/work/build/tmp/deploy/images/generic-amd64/balena-image-generic-amd64.balenaos-img.sig': No such file or directory
The signed image symlink is not generated before the flasher needs it so we avoid this dependency issue by defining a new image type for which the build system will automatically create the appropriate symlink.
Change-type: patch
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines