-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: Mark removed languages + distros as EOL #3008
Conversation
@vipulgupta2048 does this look ok to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR. An update to this page is long due. Found some corrections if you can make them, we have to work towards automating this page completely but haven;t been able to reach that goal.
Some of these versions of balena base images might not even exist as well.
- [Ubuntu](https://www.ubuntu.com/): xenial (16.04), bionic (18.04), focal (20.04), impish (21.10), kinetic (22.10) and jammy (22.04) | ||
- [Fedora](https://getfedora.org/): 36, 37 and 38 | ||
- [Ubuntu](https://www.ubuntu.com/): xenial (16.04), bionic (18.04), focal (20.04), impish (21.10) (EOL), kinetic (22.10) (EOL) , jammy (22.04) and lunar (23.04) (EOL) | ||
- [Fedora](https://getfedora.org/): 36 (EOL), 37 and 38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, 37 and 38 are EOL as well: https://endoflife.date/fedora
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mark them as EOL because contacts continues building them even though they are EOL. Do you need to mark them as EOL based on the https://endoflife.date/fedora and not reflect the contracts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning that, we definitely don't want to list versions we aren't building anymore. I have already figured out a way to automate this page, but I have been busy with something. Would be able to take this on next sprint, automate this page and maybe we can add the EOL notices automatically as a stretch feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vipulgupta2048 Ok so for all the versions that their contract have been removed (i.e nodejs 16.19.1) balena-io/contracts#421 should i change the docs and remove them completly? Right now my proposed patch doesn't seem to follow what you are describing or should we wait for the automation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that out. Indeed, let's wait for the automation. I will be able to work on after 2 weeks as our current work cycle ends and we bet on this work since there are a lot of moving parts to get this page automated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. So @vipulgupta2048 will leave this open till the merge of the automation finish just for reference.Feel free to close it when the automation is done or mention me to mark it as closed.
@@ -19,18 +19,19 @@ excerpt: Docker images maintained by balena | |||
- Multiple Distributions: | |||
- [Debian](https://www.debian.org/): buster (10), bullseye (11), bookworm (12) and sid | |||
- [Alpine](https://alpinelinux.org/): 3.12, 3.13, 3.14, 3.15, 3.16, 3.17 and edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Alpine](https://alpinelinux.org/): 3.12, 3.13, 3.14, 3.15, 3.16, 3.17 and edge | |
- [Alpine](https://alpinelinux.org/): 3.12, 3.13, 3.14, 3.15, 3.16, 3.17 and edge |
If you can, can you please update the other entries as well! https://endoflife.date/alpine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sure no problem
Update docs to reflect the changes of these pull requests balena-io/contracts#421 balena-io/contracts#422 balena-io/contracts#423 + added jdk 17 in the supported language stacks
@vipulgupta2048 Did the changes that you asked + checked for more languages and distros from https://endoflife.date. |
Review #3053 please for the automated generation of these details now. |
Thank you for your contribution, it provided us with the correct push for us to work on this pending project and really improve our base images documentation. |
Update docs to reflect the changes of these pull requests
balena-io/contracts#421
balena-io/contracts#422
balena-io/contracts#423