hw.device-type: Fix compatibility with existing sdk structure #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Alexandru Costache <[email protected]>
vipulgupta2048
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we've got a few words appended to the bootDevice partial from https://github.com/balena-io/balena-sdk/blob/master/src/models/balenaos-contract.ts#L31 , and this results in an instruction step like this:
Power up the Nvidia Jetson Orin Nano 8GB (SD) Devkit NVME. If you have a display or a debug UART cable connected to the device, a progress bar will show up while the UEFI firmware is updated. Please do not interrupt this process by turning off power or rebooting the device. to boot the device.
Rather than removing "to boot the device" from the sdk and updating every other device-type contract with that, I'm thinking of re-wording "bootDevice" only for these Orin device-types to :
"... Please do not interrupt this process by turning off power or rebooting the device. Once the firmware update completes, no other steps are needed "
so that the appended "to boot the device" makes sense in this context.
Change-type: patch