Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sys period field by default in create table #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

izavits
Copy link

@izavits izavits commented Sep 8, 2016

@resin-jenkins
Copy link

Can one of the admins verify this patch?

@Page-
Copy link
Contributor

Page- commented Sep 8, 2016

add to whitelist

@@ -29,6 +29,13 @@ createdAtField =
index: null
references: null
defaultValue: 'CURRENT_TIMESTAMP'
sysPeriodField =
dataType: 'Date Time Range'
fieldName: 'sys period'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "sys period" mean?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means system period. It is a range showing when a record is valid from-to. The temporal extension's convention it to call it "sys period" that's why I named it that way.

@izavits
Copy link
Author

izavits commented Oct 5, 2016

I'm not sure I get it 100%. sbvr-types exports only the available data types. Should dataTypeGen be defined in TypeUtils.coffee and exported somehow in order for abstract-sql-compiler to be able to use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants