Add option to replace Serial with Integer #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
reviewed
Dec 10, 2024
src/generate.ts
Outdated
| @@ -34,6 +40,7 @@ const sqlTypeToTypescriptType = ( | |||
| m: RequiredModelSubset, | |||
| f: AbstractSqlField, | |||
| mode: Mode, | |||
| opts?: Options, | |||
There was a problem hiding this comment.
I think the opts argument should be required on all functions except the exported abstractSqlToTypescriptTypes where it can be a default, ie opts: Options = {},
joshbwlng
force-pushed
the
joshbwlng/replace-serials
branch
from
9ffed15 to
479ac29
Compare
Page-
approved these changes
Dec 16, 2024
Change-type: minor
joshbwlng
force-pushed
the
joshbwlng/replace-serials
branch
from
479ac29 to
cdf0e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor