Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary setup version #33

Open
wants to merge 1 commit into
base: v1-develop
Choose a base branch
from

Conversation

sprankhub
Copy link

If I am not mistaken, this module does not rely on any setup / upgrade scripts. Hence, there is no need for a setup version. Having it still in the config means that we cannot have a zero-downtime-deployment when deploying this module (since bin/magento setup:db:status will say updates are necessary).

@hostep
Copy link
Member

hostep commented Feb 9, 2022

Thanks @sprankhub, but this module still supports Magento 2.1 and 2.2 currently (but maybe that will change in the future someday) and in those older versions this version declaration is still mandatory.

About the zero-downtime-deployment: this only happens when first installing the module I'm assuming? On further deployments it will work fine, right?

@sprankhub
Copy link
Author

Then please stop supporting 2.1 and 2.2 😂

Yes, this is a one-time issue. It is still annoying to have unnecessary downtime, though.

Thanks as usual :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants