merge from beets #376
merge from beets #376
Conversation
There was a problem hiding this comment.
As a general comment, we could improve the config around code using isBalancerProject but I think you already talked about this with @garethfuller
Approved but let's wait for Gareth to do another review.
| export function parseLstStakeReceipt({ receiptLogs, userAddress, chain, getToken }: ParseProps) { | ||
| const receivedToken: HumanTokenAmount[] = getIncomingLogs(receiptLogs, userAddress).map(log => { | ||
| const tokenDecimals = getToken(log.address, chain)?.decimals | ||
| return _toHumanAmount(log.address, log.args.value, tokenDecimals) | ||
| }) | ||
|
|
||
| return { | ||
| receivedToken, | ||
| } | ||
| } | ||
|
|
||
| export function parseLstUnstakeReceipt({ receiptLogs, userAddress, chain, getToken }: ParseProps) { | ||
| const receivedToken: HumanTokenAmount[] = getIncomingLogs(receiptLogs, userAddress).map(log => { | ||
| const tokenDecimals = getToken(log.address, chain)?.decimals | ||
| return _toHumanAmount(log.address, log.args.value, tokenDecimals) | ||
| }) | ||
|
|
||
| return { | ||
| receivedToken, | ||
| } | ||
| } | ||
|
|
||
| export function parseLstWithdrawReceipt({ receiptLogs, userAddress, chain, getToken }: ParseProps) { | ||
| const receivedToken: HumanTokenAmount[] = getIncomingLogs(receiptLogs, userAddress).map(log => { | ||
| const tokenDecimals = getToken(log.address, chain)?.decimals | ||
| return _toHumanAmount(log.address, log.args.value, tokenDecimals) | ||
| }) | ||
|
|
||
| return { | ||
| receivedToken, | ||
| } | ||
| } |
There was a problem hiding this comment.
You shouldn't need to parse receipts for staking/unstaking because there is no
slippage. The only reason we do receipt states in the add/remove/swap flow is
because the amounts can change between preview and confirmation. I think it's
likely all this should be removed.
There was a problem hiding this comment.
for the unstaking you are right, there is no token transferred at that stage so i have removed it
for staking and withdrawing though, tokens are transferred and i have updated the parsers to correctly parse the logs for that
i also updated the tests for there 2 parsers
No description provided.