refactor: PoolCore, remove pool.displayTokens, new display token functions #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Init * chore: Add logoURI to schema
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* chore: bump graphql * skip flaky test * fix integration test --------- Co-authored-by: Alberto Gualis <[email protected]>
alter-eggo
approved these changes
Dec 20, 2024
* chore: update dependencies recommended by dependabot * chore: update dependencies recommended by dependabot2
…ce in composition views
garethfuller
requested changes
Dec 20, 2024
* update pagination props * add withdraw * First pass on moving the theme towards the new brand * add tinycolor2 types * move to beets folder * add min height * fix alignment for last page * Top level pass supporting new designs * adjust input color * darken the grays, fix input bgs * update withdraw action * update provider * remove navlink * clean up grays * Revert some theme changes * darker color for active button * copy latest marketing page from balancer * rename to Stake S * chore: Landing page init * chore: Add section * Mocking additional sections * layout staked sonic section * updates for sonic * preparing for sonic * Fill in mabeets section * align card heights * Drop in staked sonic pieces * build out social club section * add staking bg * Fix grow earn svg * updated sts copy * add balancer v3 section * Add security section * feat: add new isBufferAllowed field to gql tokens * more sonic updates * fix min deposit * Add CTAs, clean up spacing * mobile cleanup pass * fix security spacing * fix for sonic * update contract addresses * change path to sts * split amounts * update relayer address * update withdraw * add faq section * update unstake & withdraw * update hardcoded balancer references * chore: Add animated title * chore: Add hero bg image * chore: Fix heading on mobile * Swap out hero text * Fix stS subheadline * update label name to suggested one * show pool creator for balancer * add balancer sdk for wagmi generate * Revert "show pool creator for balancer" This reverts commit a39b191. * chore: add sonic integration test * use correct pool creator url * put back tokens * update token input checks * refetch balances on success * only show appzi for balancer * update refetching withdrawal requests * update favicon * show dark/light switcher for balancer * update policies * rename for clarity * show pool name for beets * hide boosted and v3 * block adding liq here * add a space * fix wnativeasset address * chore: Change hero spacing * feat: LZBEETS migrator * Clean up, hook up mabeets link * Add mabeets link * fix twitter link * Use new logo * fix link * updated with infographic * fix alignment * remove sub stats * fix type error * updated banner * update footer copy * Add migration link * fill out faq * fix mobile nav * fix promo banner * Fix copy * add discord redirect * move to lib/modules * add risks page * Add better migration image * clean up migration copy * iterating on migration flow * add protocol data * remove brand assets link * update svg * update mobile nav * reduce the height * hide "to sonic" on smaller screens * add opengraph image * Swap liquidity for yield, force white for final color * update metadata * set a metadata base * update package.json * Add sonic pools list * fix build error * beets migrator * temp add ccontract * remove overrides again * add approval flow * only show boost for balancer * switch to drpc * update faq txt * add migration guide links * add links to data cards * update migrator * updated copy * add landing modal * push copy change * fix case * add sts data * manually add mc3 * chore: bump to sdk 1.0.2 * typo * add & view sts data * Add audit link * Improve validator selection * fixes * Add network dropdown for pools * add checkbox to hide modal * fix hydration error * add note to unstake flow * add sfc contract * update contracts again * fix multicall * update hook * update hook * refactor: Lst component * added stats section, hiding charts currently * shrink stats * clean up * specify bg color explicitly * set correct default network * format token amount * data hook up * extend rate label * update faq text * push updated copy * remove lzbeets migrator button here * add aprs to mabeets * remove risks link * scroll to anchor * fix mabeets apr calc * fix apr calc * use beets opengraph image * add icons * add sonic-logo * Add amount received for stake and unstake * fix missing button * Add lz beets migration modal * add network switch, uncomment code * fix approval flow * Filter pools based on connected network * use custom format * add logouri * update lst withdraw flow * add withdraw request helper * fix withdraw flow * fix: use dRPC in integration test fork * chore: add blocknumber for sonic * chore: add gnosis fork blocknumber * update customLinks * remove unstake receipt parser * update receipt parsers --------- Co-authored-by: Daniel <[email protected]> Co-authored-by: Gareth Fuller <[email protected]> Co-authored-by: Alberto Gualis <[email protected]> Co-authored-by: daniel <[email protected]>
* chore: add disallowNestedActions * chore: clean disallowNestedActions setup * chore: remove old phantom pool from disallowedNested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes on top of the big voting list PR because that contains many displayToken related changes that would conflict the the planned tokens refactor.
Main changes:
pool.displayTokenscalls.ApiTokeninstead of types likeGqlDisplayTokenpool.tokens.display.ts). Note that this is just a temporary file. Its methods and the file itself will be renamed/moved in another PR (where we will fix the logic related with pool actions andgetPoolActionableTokens).PoolCoretype to start cleaning the mess around different Pool types (Pool, PoolListItem, PoolData...) used across the Pool token display related components. (This must be simplified even more in incoming PRs but we need it now to enable previous points).TODO:The refactor is far from perfect but should unblock Voting list PR and simplify the path to a cleaner code base.
pool.tokens.display: Fixed in refactor: replace blockExplorer hook by plain TS functions #378pool.tokens.utils.tsVoteListTableRow: Different problems with pool structure (check TODOs in that file)getCompositionDisplayTokensWithPossibleNestedTokensWithBalanceTokenRowcomponents (one inTokenRowSelectList)with optional props like pool, token, apiToken...Review if we can simplify.