Feat/enable hooks sor #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f73eaa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ackend into feat/enable-hooks-sor
brunoguerios
approved these changes
Jan 13, 2025
gmbronco
requested changes
Jan 14, 2025
Comment on lines
106
to
107
| // @ts-ignore: Ignore TypeScript error for accessing name property | ||
| pool.hook?.name, |
There was a problem hiding this comment.
wouldn't it be cleaner to pass the name via the hookState? easier to manage if everything is within one scope.
There was a problem hiding this comment.
addressed the change request with the latest pushes.
gmbronco
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will enable hooks in the SOR. The key changes/additions are: