ZMQ: fixed warnings #115
ZMQ: fixed warnings #115
Conversation
modules/zmq/zmq-transport.c
Outdated
| { | ||
| LogTransportZMQ *self = (LogTransportZMQ *) s; | ||
| return zmq_recv(self->socket, buf, buflen, ZMQ_DONTWAIT); |
There was a problem hiding this comment.
Why the space? It is not a compile warning correction, is it?
|
Thank you very much for your contribution! There is still only one compile warning. (zmq-grammar Thanks for your help :) |
|
Hali, Yes it was right about the recv(). And fixed some memory leaks. Please check them. |
|
I did a compile using the two patches, but I still receive this error in the post build checks: [ 26s] E: syslog-ng-incubator 64bit-portability-issue modules/zmq/zmq-grammar.y:379 Looking at the build logs: [ 22s] CC modules/zmq/modules_zmq_libzmq_la-zmq-grammar.lo |
|
Upsz okay it is still not complete I will fix it also |
lmesz
force-pushed
the
zmq
branch
2 times, most recently
from
a1cf3c4 to
fd99882
Compare
* In the source case syslog-ng use pull socket. When you use pull socket you must connect to socket instead of bind and the other part has to bind. * E.g.: pull -> connect | push -> bind * Remove the lot of c test scripts and use python instead.
… create_zmq_context * Bug: errno wasn't set to 0 before the creation of zmq socket. So if failed to create first zmq-socket the second followed it because the error variable contained the first socket error number. * function test script: changed default port from 8888 to 5558 to be symetric with the source code
…d_* and followed the changes in test and module header
* fixed a leak around insert, syslog-ng didn't free the result if the insertion to zmq_queue() was successful * made the function names consistent
… to changed to term, but now the packaged libzmq doesn not support this function
* ZMQ contains flow-control itself * The queue is necessary to set path_options to not bother about acknowledgement * Previously there was a bug which ended in a segfault. After the first reload and message sending syslog-ng crashed because the bookmark wasn't set properly.
|
@lmesz please rebase your patch. Currently, this PR has conflicting files and therefore cannot be merged. |
Hali,
Pleases review the warning fixes.
Thanks