Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: checkinstall fails & dwm-msg not removed on uninstall #381

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Person1873
Copy link

this patch modifies the makefile to use the "install" command which behaves like cp,chmod,chown,mkdir all rolled into one. this simplifies the makefile & also makes it compatible with "checkinstall" on debian systems.

this patch modifies the makefile to use the "install" command which behaves like cp,chmod,chown,mkdir all rolled into one.
this simplifies the makefile & also makes it compatible with "checkinstall" on debian systems.
make checkinstall run more reliably
@Person1873
Copy link
Author

The reason for doing this, is so that my system has nothing installed outside the package manager, figured this may be useful for others that are also thus inclined

@bakkeby
Copy link
Owner

bakkeby commented Nov 3, 2023

I think that these kind of changes would be more something that one would try to get merged upstream (in the main dwm project) and this project would pick up the changes if they end up getting merged.

install is part of the GNU coreutils so it should in theory be available on most systems. On BSD it looks like xinstall is the equivalent.

Interestingly they have an xinstall in the suckless sbase although it does not have all the command line arguments.

@speedie1337
Copy link
Contributor

I doubt it would be merged upstream because suckless hates GNU features, and I'd imagine they believe cp sucks less or whatever despite it being an improvement in my opinion.

@Person1873
Copy link
Author

not to be contrary, but the upstream makefile doesn't include dwm-msg at all, and it only forms part of the IPC patch.
it would make sense to push that particular part of it to the IPC patch however.
this seems like the most logical place to submit to as it seem intended to simplify install of DWM (including uninstalling?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants