issue=1251, use clock_gettime(CLOCK_MONOTONIC) to get current time #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix for system time rollback
|
增加单测 |
taocp
reviewed
May 8, 2017
| int delta = 0; | ||
| delta = ts2.tv_sec - tv.tv_sec; | ||
| ASSERT_TRUE(-1 <= delta && delta <= 1); | ||
| ASSERT_TRUE(ts1.tv_sec < ts2.tv_sec); |
There was a problem hiding this comment.
ts1是MONOTONIC的；
ts2是REALTIME的；
二者不是同一个东东，比较是啥意思。。
There was a problem hiding this comment.
第一个断言，想说明gettimeofday和CLOCK_REALTIME两个函数获得的时间是一致的；
第二个断言，说明monotonic函数确实是取了系统启动后的时间，应该恒小于CLOCK_REALTIME
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for system time rollback