Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加 warning 根组件为 <fragment> 时不支持反解 close #98 #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: 增加 warning 根组件为 <fragment> 时不支持反解 close #98 #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/compilers/anode-compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ export class ANodeCompiler<T extends 'none' | 'typed'> {
if (TypeGuards.isAForNode(aNode)) return this.compileFor(aNode)
if (TypeGuards.isASlotNode(aNode)) return this.compileSlot(aNode)
if (TypeGuards.isATemplateNode(aNode)) return this.compileTemplate(aNode)
if (TypeGuards.isAFragmentNode(aNode)) return this.compileFragment(aNode)
if (TypeGuards.isAFragmentNode(aNode)) {
if (isRootElement) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

子组件根是fragment 时，不应该报warning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太确定了，你用san实际试一下

console.warn('根元素为 <fragment> 不支持反解')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码里的报错，用简单的英文

}
return this.compileFragment(aNode)
}

const childComponentReference = this.generateRef(aNode)
if (childComponentReference) {
Expand Down