Messy refactoring for vim-buffet logic
#40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 7, 2019 11:13
…a cheaking function for `term & quickfix` section
…unction but i think this kind of messy
- Add some comments to clear buffet#update() intention - Fix and split s:InitAndRecordOcc() to 2 distinct functions
|
This is a lot of work @baIIoon! Thank you for that, I will have a careful look in a few days! |
|
Thank you so much for invited me. As I said in #32 (comment). This PR just to show you the idea (i'm still a noob to Git so I don't know how to make you see the git diff? rather than a PR and also I just didn't test this carefully, so don't merge it). Maybe I'm working on it in Lunar New Year (I'm still not sure about it :) and have a careful testing before PR. 🌱 I think you will love this (don't know if it's realistic :) : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just show the idea of how this gonna refactor, please don't merge this to the
masterbranch