Jamf Pro API + refactoring #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! This looks really good, at first glance this all looks correct. It will take me some time to review everything. Some of what you've done here I've been meaning to but have not found the time. Thanks! |
|
It seems this pull request removes the ability to create new scripts. If the ID is missing from the XML it does catch that, but never creates the script in Jamf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses the Jamf Pro API to:
Created
file_contentsto reduce code duplication.Abstracted
get_templateto be used by both scripts and extension attributes.Set the default of the limit parameter to 5 and capped it at 25.