CMake fixes #29
Open
CMake fixes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! I'm out until 23.01, expect further response then. |
|
ping |
|
I think we can't accept those changes as they are. Do they pose a problem for your build? |
|
Yes - without those |
|
Oh, now that I'm not on mobile I see the failed CI jobs. That's ok, the first commit ("Drop superfluous language from CMakeLists") is only a minor optimisation that works on my platform due to linking with system zlib, while in other cases you probably build your own copy? I can drop that, the only fix required is the other commit. |
|
Yeah, that'll do, but I need to figure out how to add Ninja to the runner - I'm having a fun time ;) https://github.com/backtrace-labs/crashpad/actions/workflows/main.yml |
This fixes compatibility with CMake's Ninja generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compatibility with
Ninjagenerator