Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): add golangci-lint for PRs #19

Merged
merged 4 commits into from
Sep 18, 2024
Merged

chore(CI): add golangci-lint for PRs #19

merged 4 commits into from
Sep 18, 2024

Conversation

MateuszKepczynskiSauce
Copy link
Collaborator

No description provided.

@MateuszKepczynskiSauce MateuszKepczynskiSauce added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin chore labels Sep 18, 2024
@MateuszKepczynskiSauce MateuszKepczynskiSauce force-pushed the chore/ci-add-golint branch 2 times, most recently from 854c4fd to c8259b8 Compare September 18, 2024 08:17
konraddysput
konraddysput requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use one cicd pipeline for testing

.github/workflows/run-unit-tests.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Outdated Show resolved Hide resolved
bcd_sys_linux.go Outdated Show resolved Hide resolved
konraddysput
konraddysput reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

.github/workflows/tests.yml Outdated Show resolved Hide resolved
konraddysput
konraddysput approved these changes Sep 18, 2024
View reviewed changes
.github/workflows/tests.yml Show resolved Hide resolved
@MateuszKepczynskiSauce MateuszKepczynskiSauce merged commit cbbcbf2 into master Sep 18, 2024
5 of 6 checks passed
@MateuszKepczynskiSauce MateuszKepczynskiSauce deleted the chore/ci-add-golint branch September 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konraddysput konraddysput konraddysput approved these changes

Assignees

@MateuszKepczynskiSauce MateuszKepczynskiSauce

Labels
chore feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MateuszKepczynskiSauce @konraddysput