Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @useoptic/optic to v1 #874

Closed
wants to merge 1 commit into from

Conversation

backstage-goalie[bot]
Copy link
Contributor

@backstage-goalie backstage-goalie bot commented Aug 17, 2024

This PR contains the following updates:

Package Type Update Change
@useoptic/optic devDependencies major ^0.55.0 -> ^1.0.0

Release Notes

opticdev/optic (@​useoptic/optic)

v1.0.0

Compare Source

Changelog

  • Removed deprecated capture commands, this included oas subcommands, optic update, optic new, optic verify and optic setup-tls - use optic capture instead
  • Removed connections to optic cloud servers (uploading saved data - e.g. OpenAPI specs, hosted rulesets / rules, loading saved data, etc)
    • optic run is no longer supported - use optic diff-all (example: diff against base tags optic diff-all --compare-from main)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@backstage-goalie backstage-goalie bot requested a review from a team as a code owner August 17, 2024 21:09
@backstage-goalie backstage-goalie bot added the dependencies Pull requests that update a dependency file label Aug 17, 2024
@backstage-goalie backstage-goalie bot requested a review from awanlin August 17, 2024 21:09
@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch 7 times, most recently from 4057109 to 2ec8adc Compare August 21, 2024 19:20
@awanlin
Copy link
Contributor

awanlin commented Aug 21, 2024

Hi @BethGriggs, took a look and best I can tell this isn't being used in code anywhere? Could we just delete this dev dependency?

@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch 5 times, most recently from ab2e677 to 522aa98 Compare August 23, 2024 13:20
@awanlin
Copy link
Contributor

awanlin commented Aug 23, 2024

Hi @jkilzi, can we remove this dev dependency, it does not look to be used best I can tell?

@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch 3 times, most recently from b9f8329 to be96f9e Compare August 23, 2024 19:19
@backstage-goalie backstage-goalie bot changed the title chore(deps): update dependency @useoptic/optic to v1 Update dependency @useoptic/optic to v1 Aug 23, 2024
@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch 9 times, most recently from 1dd51ba to ac34705 Compare August 24, 2024 22:19
@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch from ac34705 to 4c521f1 Compare August 24, 2024 23:21
@jkilzi
Copy link
Contributor

jkilzi commented Aug 25, 2024

Hi @jkilzi, can we remove this dev dependency, it does not look to be used best I can tell?

Unfortunately no. It is declared as a peerDependency of @backstage/repo-tools, which we use to generate a client from an openapi.yaml spec file.

@jkilzi
Copy link
Contributor

jkilzi commented Aug 25, 2024

@awanlin, BTW, I'm not sure it is going to work the same way it did if you bump it from v0.55.0 to v1.0.0

@awanlin
Copy link
Contributor

awanlin commented Aug 25, 2024

Thanks for the follow up @jkilzi, should we close this PR then? That will pin it at this version range until a point where we upgrade this manually.

@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch 3 times, most recently from 7ef1840 to e68bb3e Compare August 27, 2024 11:20
@backstage-goalie backstage-goalie bot changed the title Update dependency @useoptic/optic to v1 chore(deps): update dependency @useoptic/optic to v1 Aug 27, 2024
@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch from e68bb3e to 8d01af6 Compare August 27, 2024 12:21
@backstage-goalie backstage-goalie bot force-pushed the renovate/useoptic-optic-1.x branch from 8d01af6 to dd70816 Compare August 27, 2024 14:21
@nickboldt nickboldt closed this Aug 27, 2024
@backstage-goalie
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 1.x releases. But if you manually upgrade to 1.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants