redhat-resource-optimization: bump backstage to 1.34.2 and remove @spotify/prettier-config #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljesusg
requested review from
jkilzi,
christoph-jerolimov and
a team
as code owners
Changed Packages
|
04kash
reviewed
Jan 16, 2025
workspaces/redhat-resource-optimization/.changeset/old-needles-deny.md
Outdated
Show resolved
Hide resolved
04kash
previously requested changes
Jan 16, 2025
aljesusg
force-pushed
the
bump_rh_resource
branch
from
134fbdc to
1760fba
Compare
|
Lgtm @aljesusg! not giving explicit approval as I'd one of the plugin owners (@christoph-jerolimov @jkilzi) to take a look as well |
christoph-jerolimov
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
The code change lgtm, but I would prefer it if @jkilzi could verify that this still works. :)
…otify/prettier-config Signed-off-by: Alberto Gutierrez <[email protected]>
04kash
force-pushed
the
bump_rh_resource
branch
from
f4e4b2f to
72799f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
bump backstage to 1.34.2 and remove @spotify/prettier-config
#2477
✔️ Checklist
Signed-off-byline in the message. (more info)